Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: 1.17.0.1841 -> 1.18.0.1944 #71045

Merged
merged 1 commit into from Oct 22, 2019
Merged

plex: 1.17.0.1841 -> 1.18.0.1944 #71045

merged 1 commit into from Oct 22, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Oct 12, 2019

Motivation for this change

Update to latest non plex pass version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @colemickens @Forkk @LnL7 @pjones @thoughtpolice

@elseym
Copy link
Member

elseym commented Oct 13, 2019

the latest non-plexpass version i can see is 1.18.0.1913-e5cc93306 (via https://plex.tv/api/downloads/5.json and the plex web app).

where did you find 1.18.0.1944-f2cae8d6b?

@bachp
Copy link
Member Author

bachp commented Oct 14, 2019

@elseym I found it on https://www.plex.tv/media-server-downloads/ I currently see the same version for both plex pass and non plex pass version. Maybe a glitch in the website if logged in?

@liamdiprose
Copy link
Contributor

Shows 1.18.0.1944-f2cae8d6b for me, not signed in.

@elseym
Copy link
Member

elseym commented Oct 15, 2019

maybe something was out of sync. now i get 1.18.0.1944-f2cae8d6b as well. 🤔

anyways, deployed your branch a couple of hours ago, works just fine. thanks 👍

@globin globin merged commit 03df08a into NixOS:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemickens colemickens Awaiting requested review from colemickens

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@LnL7 LnL7 Awaiting requested review from LnL7

@pjones pjones Awaiting requested review from pjones

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @elseym @liamdiprose @globin