New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poppler: add patch for CVE-2019-9959 #71046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
force-pushed
the
ris-poppler-CVE-2019-9959
branch
from
October 12, 2019 17:55
9858d08
to
2d09ae0
Compare
Rebased to staging because of huge rebuild. |
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
Oct 12, 2019
#60701 is not ready. It makes sense to apply this to master as well instead of rushing an upgrade. |
Ok... what order should we do this in? |
@risicle Usually we apply fix to master first and then "git cherry-pick -x" to the stable branch. |
Right... I guess I'll rebase this PR then as a start. |
risicle
force-pushed
the
ris-poppler-CVE-2019-9959
branch
from
October 13, 2019 00:53
2d09ae0
to
1316edd
Compare
ofborg
bot
added
8.has: clean-up
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 2501-5000
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
and removed
6.topic: haskell
6.topic: lua
6.topic: nixos
6.topic: python
6.topic: qt/kde
6.topic: vim
8.has: documentation
8.has: module (update)
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
10.rebuild-darwin: 501+
10.rebuild-darwin: 2501-5000
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
Oct 13, 2019
ttuegel
approved these changes
Oct 13, 2019
Are you going to do the cherry picks or shall I create separate PRs? |
vcunat
pushed a commit
that referenced
this pull request
Oct 13, 2019
(cherry picked from commit 3fa2864)
vcunat
added
8.has: port to stable
A PR already has a backport to the stable release.
and removed
9.needs: port to stable
A PR needs a backport to the stable release.
labels
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.severity: security
8.has: clean-up
8.has: package (new)
8.has: port to stable
A PR already has a backport to the stable release.
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2019-9959
For the main poppler package, we should be looking at merging #60701.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @