Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calibre: 3.47.1 -> 4.1.0 #71004

Closed
wants to merge 1 commit into from
Closed

calibre: 3.47.1 -> 4.1.0 #71004

wants to merge 1 commit into from

Conversation

esclear
Copy link
Contributor

@esclear esclear commented Oct 11, 2019 •
edited

Motivation for this change

The calibre ebook management software has been updated to version 4.1.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar @pSub @AndersonTorres

@esclear esclear changed the title calibre: 3.47.1 -> 4.1.0 [WIP] calibre: 3.47.1 -> 4.1.0 Oct 11, 2019
AndersonTorres
AndersonTorres approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndersonTorres
Copy link
Member

Remember me when it reaches 15 days!

@esclear esclear changed the title [WIP] calibre: 3.47.1 -> 4.1.0 calibre: 3.47.1 -> 4.1.0 Oct 20, 2019
@esclear
Copy link
Contributor Author

esclear commented Oct 20, 2019

I got to do some research about calibre's executables.
Some will throw exceptions, since some environment variables are not set (which was already the case before the update), but if one supplies the correct variables, they seem to work properly.

@ari-becker
Copy link
Contributor

@esclear anything new?
I'm actively waiting on this because I have a shared library where the calibre on other machines is already updated to 4+, and the database format changed between 3.x and 4.x, so it's keeping me from using calibre on my NixOS machine.
Thanks

@Lassulus
Copy link
Member

Lassulus commented Dec 8, 2019

needs rebasing

@callahad
Copy link
Member

Looks like this has been superseded by #77616

Can someone please close this PR?

@esclear esclear closed this Jan 23, 2020
@esclear esclear deleted the update-calibre branch January 23, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@pSub pSub Awaiting requested review from pSub

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@esclear @AndersonTorres @ari-becker @Lassulus @callahad