New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttygif init at 1.4.0 #71007
ttygif init at 1.4.0 #71007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
executable seems to work
[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71007
1 package were build:
ttygif
@GrahamcOfBorg build ttygif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mark this as broken on x86_64-darwin.
@matthewbauer I not sure if I did this right. I set the platform to platforms.linux. Does this work or did you have something else in mind? |
that works |
@GrahamcOfBorg build ttygif |
Motivation for this change
add ttygif to nixpkgs
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @