Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups: 2.2.12 -> 2.3.0 #70969

Merged
merged 1 commit into from Nov 2, 2019
Merged

cups: 2.2.12 -> 2.3.0 #70969

merged 1 commit into from Nov 2, 2019

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 11, 2019 •
edited

Motivation for this change

(Maybe) Fix #69559 Just a normal update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer

@ofborg ofborg bot requested a review from matthewbauer October 11, 2019 12:07
@jonringer
Copy link
Contributor

do you mind switching this to the staging branch? master should really only be targeted if it's <100 rebuilds, a security patch, or fixing an already broken build.

Otherwise people may have to build hundreds of packages to test their own PR.

@doronbehar doronbehar changed the base branch from master to staging October 12, 2019 07:38
@FRidh
Copy link
Member

FRidh commented Oct 22, 2019

Please run the nixos tests.

@FRidh FRidh added this to New in Staging Oct 24, 2019
@FRidh FRidh moved this from New to Needs review in Staging Oct 24, 2019
@doronbehar
Copy link
Contributor Author

It took me a while to find https://nixos.org/nixos/manual/index.html#sec-running-nixos-tests-interactively and from some reason it had me building qemu from scratch. Here are the results:

result.zip

@jonringer
Copy link
Contributor

generally the tests can be ran locally with: nix-build -A nixosTests.<name>

@doronbehar
Copy link
Contributor Author

doronbehar commented Oct 24, 2019 via email

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/63

@markuskowa
Copy link
Member

@GrahamcOfBorg test cups printing

@markuskowa markuskowa merged commit c683b19 into NixOS:staging Nov 2, 2019
@FRidh FRidh moved this from Needs review to Merged in Staging Nov 3, 2019
@doronbehar doronbehar deleted the update-cups branch March 2, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@doronbehar @jonringer @FRidh @nixos-discourse @markuskowa