@GrahamcOfBorg build devilutionx

@karolchmist are you able to address the darwin failure?

No, I don't see why it failed... Seems like it compiles, and then fails in install phase. I don't have macOs. What can we do? Maybe remove darwin from the platform list?

cp: cannot stat 'devilutionx': No such file or directory

Seems like a differently named executable is produced on darwin. If we had access to a darwin box we could simply insert an echo to tell us what is in that directory and go from there...

@aanderse I pushed a commit that lists the content of the output folder. On darwin, it's :

[100%] Linking CXX executable devilutionx.app/Contents/MacOS/devilutionx
Copying OS X content devilutionx.app/Contents/Resources/AppIcon.icns
Copying OS X content devilutionx.app/Contents/Resources/CharisSILB.ttf
[100%] Built target devilutionx
installing
total 14932
drwxr-xr-x 16 nixbld1 nixbld      544 Oct 16 14:32 .
drwxr-xr-x 27 nixbld1 nixbld      918 Oct 16 14:30 ..
-rw-r--r--  1 nixbld1 nixbld        2 Jan  1  1970 .gitignore
-rw-r--r--  1 nixbld1 nixbld    35343 Oct 16 14:30 CMakeCache.txt
drwxr-xr-x 17 nixbld1 nixbld      578 Oct 16 14:33 CMakeFiles
-r--r--r--  1 nixbld1 nixbld     3870 Oct 16 14:30 CPackConfig.cmake
-r--r--r--  1 nixbld1 nixbld     4347 Oct 16 14:30 CPackSourceConfig.cmake
-rw-r--r--  1 nixbld1 nixbld   132032 Oct 16 14:30 Makefile
-rw-r--r--  1 nixbld1 nixbld     1731 Oct 16 14:30 cmake_install.cmake
-rw-r--r--  1 nixbld1 nixbld       77 Oct 16 14:30 config.h
drwxr-xr-x  3 nixbld1 nixbld      102 Oct 16 14:30 devilutionx.app
-rw-r--r--  1 nixbld1 nixbld    18512 Oct 16 14:32 libPKWare.a
-rw-r--r--  1 nixbld1 nixbld    43848 Oct 16 14:32 libRadon.a
-rw-r--r--  1 nixbld1 nixbld   103104 Oct 16 14:32 libStormLib.a
-rw-r--r--  1 nixbld1 nixbld 14875984 Oct 16 14:32 libdevilution.a
-rw-r--r--  1 nixbld1 nixbld    42976 Oct 16 14:30 libsmacker.a

It seems like devilutionx.app is the executable file.

Do you know what we should do in this case?

@karolchmist unfortunately I've never really used darwin much before so even the most basic specifics of the system elude me.

ping @lilyball as someone who might be generous and share basic darwin knowledge with us ❤️

Maybe @jsamsa wouldn't mind taking 30 seconds to explain an extremely basic darwin concept to us so you can finish this PR up... 🤔

mv devilutionx.app $out/Applications

There might be a binary that could (should) be moved to $out/bin as well. I'm not familiar with this package so, not sure myself. Have a look at pkgs/development/tools/electron/default.nix as an example

Thanks for your help @aanderse and @jsamsa . I tried to make sense of how to build it on Darwin, but I gave up because I wasn't sure what I was doing. Even if it builds, I can't test it properly.

If one day someone is willing to make it work, I'd be happy to help. Until then, I prefer to remove the support for Darwin. It's a niche game, and I don't think anybody cares...

To finish on a positive note: I re-enabled the hardening for the format flag, since it passes for the current version of the project.

@karolchmist alright. Too bad, but we don't have the hardware so if someone wants darwin support they'll have to add themselves to the maintainers list I guess.

Can you please format your commit messages as per nixpkgs standard? As in:

• devilutionx: unstable-2019-07-28 -> 0.5.0
• devilutionx: Remove darwin platform due to build errors
• devilutionx: Remove hardeningDisable = [ "format" ]

Or squash all commits into:

• devilutionx: unstable-2019-07-28 -> 0.5.0

Thanks!

@jsamsa's suggestion looks correct. The output as listed in your comment is devilutionx.app, which is a folder structure that contains the executable (among other things). The whole devilutionx.app is the GUI app and should be moved into $out/Applications as already recommended. I don't see anything in that output that obviously needs to be moved elsewhere either.

I don't have diabdat.mpq but I was able to run the app on darwin and get the screen telling me it's missing (I am curious how it's supposed to work with a Nix install though; where does the file go?)

Here's the diff applied to get to this point:

diff --git a/pkgs/games/devilutionx/default.nix b/pkgs/games/devilutionx/default.nix
index 63149aff678..650d12c112b 100644
--- a/pkgs/games/devilutionx/default.nix
+++ b/pkgs/games/devilutionx/default.nix
@@ -17,10 +17,13 @@ stdenv.mkDerivation rec {
 
   installPhase = ''
     runHook preInstall
-
+  '' + (if stdenv.isDarwin then ''
+    mkdir -p $out/Applications
+    mv devilutionx.app $out/Applications
+  '' else ''
     mkdir -p $out/bin
     cp devilutionx $out/bin
-
+  '') + ''
     runHook postInstall
   '';
 
@@ -29,6 +32,6 @@ stdenv.mkDerivation rec {
     description = "Diablo build for modern operating systems";
     license = licenses.unlicense;
     maintainers = [ maintainers.karolchmist ];
-    platforms = platforms.linux ++ platforms.windows;
+    platforms = platforms.linux ++ platforms.darwin ++ platforms.windows;
   };
 }

Thank you for your detailed explanation @lilyball! You are exceptional, as always! Generally how these open source forks/remakes of proprietary games work is that they ask you to put the game data in a predefined location like ~/.local/share/GAME.

@karolchmist at this point @lilyball has handed us the solution... If you don't mind can you please keep darwin support?

My question with diabdat.mpq is because the instructions say

Copy diabdat.mpq from your CD, or GoG install folder, to the DevilutionX install folder; Make sure it is all lowercase.

That makes it sound like it's supposed to be sitting next to the executable, which obviously doesn't work with Nix (for any platform).

That said, after digging through all of the code it does appear that if it can't find the file next to the executable it falls back to $HOME/.local/share/diasurgical/devilution/, so the Nix install should work fine even on macOS. I just wish this was documented.

Hey @lilyball, thanks for you help! I pushed a version with your solution for Darwin.

How would you document the location for diabdat.mpq? Just in the description?

longDescription should be fine.

@GrahamcOfBorg build devilutionx

@karolchmist small suggestion on wording. Looking good. Thanks again @lilyball 🎉