Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase: 4.3.1 -> 4.6.0 #70940

Merged
merged 2 commits into from Oct 16, 2019
Merged

keybase: 4.3.1 -> 4.6.0 #70940

merged 2 commits into from Oct 16, 2019

Conversation

judaew
Copy link
Contributor

@judaew judaew commented Oct 10, 2019 •
edited

Motivation for this change

Update to version 4.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@judaew judaew mentioned this pull request Oct 10, 2019
Closed
10 tasks
@jonringer
Copy link
Contributor

@GrahamcOfBorg build kbfs keybase keybase-gui

jonringer
jonringer approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work

[6 built, 83 copied (370.3 MiB), 85.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70940
3 package were build:
kbfs keybase keybase-gui

@jonringer jonringer merged commit 8f118b1 into NixOS:master Oct 16, 2019
@worldofpeace
Copy link
Contributor

@judaew For your future contributions, keep in mind updates commit messages should be formatted like

keybase: 4.3.1 -> 4.6.0
keybase-gui: 4.3.1 -> 4.6.0

@jonringer
Copy link
Contributor

I apologize, I should have caught that :(

@judaew
Copy link
Contributor Author

judaew commented Oct 16, 2019

I did not know about it, but I will take this into account. Thanks!

@worldofpeace
Copy link
Contributor

@judaew It should all be in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md, specifically https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes.

Though I must admit it's not exactly an easy read for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@judaew @jonringer @worldofpeace