Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.block-io: propagate setuptools #70942

Merged
merged 1 commit into from Oct 11, 2019
Merged

pythonPackages.block-io: propagate setuptools #70942

merged 1 commit into from Oct 11, 2019

Conversation

nyanloutre
Copy link
Member

Used during runtime

Motivation for this change

Should be backported to 19.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before:

$ nix-shell --pure -p python3Packages.block-io

[nix-shell:/home/jon/projects/nixpkgs]$ python
Python 3.7.4 (default, Jul  8 2019, 18:31:06)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import block_io
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nix/store/96qbpvxy8fpa9z9ps5cr34fpvbaipa4r-python3.7-block-io-1.1.10/lib/python3.7/site-packages/block_io/__init__.py", line 7, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

after:

[nix-shell:/home/jon/.cache/nix-review/pr-70942]$ nix-shell --pure -p "with import ./nixpkgs {}; python3Packages.block-io"

[nix-shell:/home/jon/.cache/nix-review/pr-70942]$ python
Python 3.7.4 (default, Jul  8 2019, 18:31:06)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import block_io
>>>

[3 built, 5 copied (0.5 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70942
2 package were build:
python27Packages.block-io python37Packages.block-io

@jonringer jonringer merged commit 9cf81e9 into NixOS:master Oct 11, 2019
@jonringer
Copy link
Contributor

thanks for submitting a PR @nyanloutre

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 11, 2019
@jonringer
Copy link
Contributor

backported as b562f70

@nyanloutre nyanloutre deleted the block_io_propagate_setuptools branch October 21, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @jonringer