Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsqldb: 1.8.0 -> 2.5.0 #70941

Merged
merged 1 commit into from Nov 8, 2019
Merged

hsqldb: 1.8.0 -> 2.5.0 #70941

merged 1 commit into from Nov 8, 2019

Conversation

cko
Copy link
Member

@cko cko commented Oct 10, 2019

Motivation for this change
  • Meta data were incomplete
  • package name was misleading
  • update available
  • r-ryantm couldn't update the package, I guess because the version wasn't parametrized
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/78

@cko
Copy link
Member Author

cko commented Nov 8, 2019

@c0bw3b many thanks for your feedback. I updated the PR accordingly.

c0bw3b
c0bw3b reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

Result of nix-review pr 70941 1

1 package were build:
  • hsqldb

@cko
Copy link
Member Author

cko commented Nov 8, 2019

@c0bw3b fixed. Please have another look.

c0bw3b
c0bw3b approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cko

@c0bw3b c0bw3b merged commit 88551f9 into NixOS:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cko @nixos-discourse @c0bw3b