Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql_12: init at 12.0 #70984

Closed
wants to merge 1 commit into from
Closed

postgresql_12: init at 12.0 #70984

wants to merge 1 commit into from

Conversation

lsix
Copy link
Member

@lsix lsix commented Oct 11, 2019

Motivation for this change

Postgresql-12 is out !

This PR adds it.

I had to change the pgdumpOptions in he dump service test since in pg_12, pg_dump does not have a -o|--oids option anymore. I think the default option of the service should be changed to -Cb to avoid this problem for people using postgresql_12, but for the time being, I have only changed it in the test.

cc @zagy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danbst
Copy link
Contributor

danbst commented Oct 11, 2019

This is duplicate - pg12 was already merged, but to staging
#70363

@lsix
Copy link
Member Author

lsix commented Oct 11, 2019

@danbst you are right, I missed it.

Closing this one.

@lsix lsix closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants