sshping: init at 0.1.4 #71019
Merged
sshping: init at 0.1.4 #71019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmahut
reviewed
Oct 16, 2019
|
|
||
| src = fetchFromGitHub { | ||
| owner = "spook"; | ||
| repo = "sshping"; |
There was a problem hiding this comment.
Suggested change
| repo = "sshping"; | |
| repo = name; |
There was a problem hiding this comment.
Not sure it would be clearer.
mmahut
reviewed
Oct 16, 2019
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/spook/sshping; |
There was a problem hiding this comment.
Suggested change
| homepage = https://github.com/spook/sshping; | |
| homepage = "https://github.com/spook/sshping"; |
mmahut
reviewed
Oct 16, 2019
| buildInputs = [ libssh ]; | ||
|
|
||
| buildPhase = '' | ||
| g++ -Wall -I ext/ -o bin/sshping src/sshping.cxx -lssh |
There was a problem hiding this comment.
Why not to use the upstream's Makefile?
There was a problem hiding this comment.
The upstream Makefile has a hardcoded path for libssh.h (/usr/include/libssh/libssh.h). Since the build a single command, I think it's slightly simpler to have it here than it would be to fix the Makefile.
|
@GrahamcOfBorg build sshping |
jqueiroz
force-pushed
the
jqueiroz/sshping
branch
from
7f18a14
to
42738db
Compare
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Nov 10, 2019
sshping: init at 0.1.4 (cherry picked from commit 495f4ee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)