Put GitHub event data in task.extra and download it #18930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
force-pushed
the
download_task_data
branch
from
7809d02
to
adcb403
Compare
|
Changes look sensible but something is still wrong: https://tools.taskcluster.net/groups/Z5kR-g-rQ2Oy2Iy6hSYwLA/tasks/VK1Klzn0S42Sk9hyyPbS_Q/details Happy to review when it's ready, just poke me. |
This avoids the problem where over-large GH events (e.g. with many changes) end up causing an exception in libcontainer when it tries to pass the data to exec. The tradeoff is that we add an extra HTTP request to the task setup.
jgraham
force-pushed
the
download_task_data
branch
from
adcb403
to
d86fefe
Compare
|
The Azure Pipelines failure is obviously unrelated, but #18934 is to "fix" it. |
foolip
approved these changes
Sep 9, 2019
This was referenced Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the problem where over-large GH events (e.g. with many
changes) end up causing an exception in libcontainer when it tries to
pass the data to exec.
The tradeoff is that we add an extra HTTP request to the task setup.