qt5.12: Add patches for QTBUG-73459 and QTBUG-69077 #68351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ttuegel
requested changes
Sep 15, 2019
QT 5.12 introduced a regression, where a QT program wouldn't show its tray icon, if there was no tray bar during program startup. (QTBUG-73459) QT 5.12 introduced a regression, where qtwebengine applications would freeze in some wayland compositors if a surface from the instance was not visible (for example having a qutebrowser window on another workspace in sway would freeze all qutebrowser windows). Both got fixed already in Qt 5.12.4, but according to #57042 and its sibling issues/PRs it doesn't seem to get fixed in near future for nixpkgs.
|
@ttuegel any more changes required? |
ghost
mentioned this pull request
10 tasks
ttuegel
approved these changes
Sep 18, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been including the qtwayland packages on my system for months now, since it always seemed like qt 5.12.4 or qt 5.13 were just around the corner. These are just super annoying bugs that I can not live with and I can not wait for the qt 5.12.4 update personally, and I think others would like to have them fixed too.
replaces #63775
QT 5.12 introduced a regression, where a QT program wouldn't show its
tray icon, if there was no tray bar during program startup. (QTBUG-73459)
QT 5.12 introduced a regression, where qtwebengine applications would
freeze in some wayland compositors if a surface from the instance was not
visible (for example having a qutebrowser window on another workspace in
sway would freeze all qutebrowser windows).
Both got fixed already in Qt 5.12.4, but according to #57042 and its
sibling issues/PRs it doesn't seem to get fixed in near future for
nixpkgs.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @