Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is 25%.

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files          34       34           
  Lines        5647     5647           
  Branches     1160     1160           
=======================================
  Hits         4638     4638           
  Misses        864      864           
  Partials      145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476ce15...474a14e. Read the comment docs.

The current behavior is intentional. What are you trying to do?

The current behavior is intentional. What are you trying to do?

I tried to shut up Vivado by passing in some write_verilog_opts options. If the current behaviour is intentional we can close this request. Specifically I'm getting critical warnings [Netlist 29-72], there was a hint to use binary, so I passed in -nohex, but it did not help anyway:

CRITICAL WARNING: [Netlist 29-72] Incorrect value '13'b1111111111111' specified for property 'init'. Expecting type 'binary' with possible values of '1'b0,1'b1'. The system will either use the default value or the property value will be dropped. Please verify your source files. [...]

Specifically I'm getting critical warnings [Netlist 29-72], there was a hint to use binary, so I passed in -nohex, but it did not help anyway.

I agree that avoiding things like "critical warnings" from Vivado is valuable. I think this should be done by adding options to emit_verilog in the appropriate platform itself, not in your designs. If you manage to find the correct combinations of options for that, please do submit a PR adding them to vendor.xilinx_*.