Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/doc: document the loaOf type deprecation #77109

Merged
merged 1 commit into from Jan 8, 2020
Merged

nixos/doc: document the loaOf type deprecation #77109

merged 1 commit into from Jan 8, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 6, 2020

Motivation for this change

Add a release note for PR #63103.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested NixOS manual builds with nix-build nixos/release.nix -A manual.x86_64-linux
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @aanderse @infinisil

@worldofpeace worldofpeace mentioned this pull request Jan 7, 2020
Closed
worldofpeace
worldofpeace approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace
Copy link
Contributor

Here's a screenshot

Screenshot from 2020-01-07 19 05 55

infinisil
infinisil approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@infinisil infinisil merged commit 32104e7 into NixOS:master Jan 8, 2020
@rnhmjoj rnhmjoj deleted the loaof-doc branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @worldofpeace @infinisil