Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: upstream no longer ships .el files for emacs #77071

Merged
merged 1 commit into from Feb 23, 2020
Merged

git: upstream no longer ships .el files for emacs #77071

merged 1 commit into from Feb 23, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

git no longer ships emacs files, so there is no point having them. In fact, it makes things worse as running this will get emacs to very loudly complain due to the shipped .el artifacts all raising errors on eval.

(require 'git)

I haven't run nix-review as this change causes significant rebuilding.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@peterhoeg
Copy link
Member Author

Cc: @peti @the-kenny @wmertens @globin

@peterhoeg peterhoeg changed the base branch from master to staging January 13, 2020 14:01
@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build git

@FRidh FRidh added this to WIP in Staging via automation Jan 15, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Jan 15, 2020
@FRidh
Copy link
Member

FRidh commented Feb 11, 2020

@GrahamcOfBorg build git

@peterhoeg
Copy link
Member Author

I cannot see how the build failures on darwin and aarch64-linux could in any way be related to this change, so I am going ahead and merging this.

@peterhoeg peterhoeg merged commit 2ddfc45 into NixOS:staging Feb 23, 2020
Staging automation moved this from Needs review to Done Feb 23, 2020
@peterhoeg peterhoeg deleted the git_emacs_files branch September 7, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@the-kenny the-kenny Awaiting requested review from the-kenny

@peti peti Awaiting requested review from peti

@wmertens wmertens Awaiting requested review from wmertens

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @FRidh