build: fix sandboxing on darwin #3303
Conversation
Starting ba87b08 getEnv now returns an std::optional which means these getEnv() != "" conditions no longer happen if the variables are not defined.
|
I also have a change that opens up the sandbox slightly, which works around the current problems it has. The current stricter approach would be nicer, but I've been using this fore quite some time now and I'd rather have this instead of nothing. LnL7@a83ab2b |
| @@ -3338,7 +3338,7 @@ void DerivationGoal::runChild() | |||
| ; | |||
| } | |||
| #if __APPLE__ | |||
| else if (getEnv("_NIX_TEST_NO_SANDBOX") == "") { | |||
| else { | |||
There was a problem hiding this comment.
Hm, why not change it to getEnv("_NIX_TEST_NO_SANDBOX").value_or("") == ""? That way you don't have to change anything else. It seems strange to initialize sandboxProfile when sandboxing is disabled.
There was a problem hiding this comment.
I noticed most of the other checks use == "1" and it doesn't hurt to make this a bit more strict since it really should only be used by the tests.
|
@LnL7 Looks like this causes a test failure on macOS: https://hydra.nixos.org/build/109896319 |
|
Hmm I don't really see how that could break it, are you sure it wasn't #3302 instead? |
|
Yes that could also be it. |
Starting ba87b08 getEnv now returns an
std::optional which means these getEnv() != "" conditions no longer happen
if the variables are not defined.