hdl.ast: replace slice.end by slice.stop in ValueKey #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the following warning which is reported when
RTLIL is generated from a design that uses slices:
nmigen/nmigen/hdl/ast.py:1505: DeprecationWarning: instead of `slice.end`, use `slice.stop`
self._hash = hash((ValueKey(self.value.value), self.value.start, self.value.end))
Signed-off-by: Pierre Surply <pierre.surply@lse.epita.fr>
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 34 34
Lines 5647 5647
Branches 1160 1160
=======================================
Hits 4638 4638
Misses 864 864
Partials 145 145
Continue to review full report at Codecov.
|
|
Never mind, it looks like this got fixed with e18385b. Thanks! |
|
Yep, I didn't merge it because I had a git stash already that became e18385b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the following warning which is reported when
RTLIL is generated from a design that uses slices:
Signed-off-by: Pierre Surply pierre.surply@lse.epita.fr