Fix: Assertion failure when post road-works cleanup removes all road pieces #7903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When road works have completed on a tile, if _settings_game.economy.mod_road_rebuild is true, CleanUpRoadBits() may remove all road bits currently on the tile.
In this case, after RemoveRoad() is called, the tile is no longer a road tile.
The subsequent call to GetRoadOwner() causes an assertion failure.
Once RemoveRoad() is called in this case, TileLoop_Road() should return early as the tile is no longer a road tile and all subsequent road tile checks/actions are no longer applicable.