Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.skorch: init at 0.8.0 #76997

Merged
merged 1 commit into from May 26, 2020
Merged

python3Packages.skorch: init at 0.8.0 #76997

merged 1 commit into from May 26, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 5, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • [NA] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bcdarwin bcdarwin changed the title skorch: init at 0.7.0 pythonPackages.skorch: init at 0.7.0 Jan 5, 2020
@bcdarwin bcdarwin changed the title pythonPackages.skorch: init at 0.7.0 python3Packages.skorch: init at 0.7.0 Jan 5, 2020
@bcdarwin bcdarwin force-pushed the skorch branch 2 times, most recently from 5b9ff7f to d5256ba Compare January 5, 2020 22:13
@FRidh
Copy link
Member

FRidh commented Jan 6, 2020

@GrahamcOfBorg build python27Packages.skorch python37Packages.skorch python38Packages.skorch

@bcdarwin
Copy link
Member Author

bcdarwin commented Jan 7, 2020

Nothing with a Pytorch dependency (even without CUDA enabled in the config) will evaluate on Hydra due to a default dependency on Intel MKL.

@bcdarwin bcdarwin changed the title python3Packages.skorch: init at 0.7.0 python3Packages.skorch: init at 0.8.0 May 9, 2020
@bcdarwin
Copy link
Member Author

bcdarwin commented May 9, 2020 •
edited

@GrahamcOfBorg build python27Packages.skorch python37Packages.skorch python38Packages.skorch

@bcdarwin
Copy link
Member Author

bcdarwin commented May 9, 2020

Rebased and build updated for Pytorch 1.4.

@bcdarwin bcdarwin requested a review from jonringer May 9, 2020 20:52
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/165

@bcdarwin bcdarwin requested a review from bhipple May 26, 2020 00:33
@bhipple
Copy link
Contributor

bhipple commented May 26, 2020

Result of nixpkgs-review pr 76997 1

2 packages built:
- python37Packages.skorch
- python38Packages.skorch

@bhipple bhipple merged commit cd9fb17 into NixOS:master May 26, 2020
@bcdarwin bcdarwin deleted the skorch branch May 26, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcdarwin @FRidh @nixos-discourse @bhipple @jonringer