Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jitterentropy: make man pages reproducible #77202

Merged
merged 1 commit into from Jan 7, 2020
Merged

jitterentropy: make man pages reproducible #77202

merged 1 commit into from Jan 7, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 7, 2020

Motivation for this change

Makes the package reproducible in the nix-build '<nixpkgs>' -A jitterentropy --check sense

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @JohnAZoidberg

@JohnAZoidberg
Copy link
Member

Thanks!
But please use fetchpatch with https://github.com/smuellerDD/jitterentropy-library/commit/0eca18fbd30318f5c2e927be307dc91e43c133b1.patch

@raboof
Copy link
Member Author

raboof commented Jan 7, 2020

Cool, I didn't know about fetchpatch. I'm not sure it will work in this case though - I tried it with fetchurl at first, but that commit doesn't apply cleanly to 2.2.0

@JohnAZoidberg
Copy link
Member

Oh, it's moved to a different line, well then it's okay.

@JohnAZoidberg JohnAZoidberg merged commit 5992086 into NixOS:master Jan 7, 2020
@raboof raboof deleted the jitterentropy-reproducible-manpages branch January 7, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @JohnAZoidberg