Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.numexpr: 2.7.0 -> 2.7.1 #77205

Merged
merged 1 commit into from Jan 7, 2020
Merged

python3Packages.numexpr: 2.7.0 -> 2.7.1 #77205

merged 1 commit into from Jan 7, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 7, 2020 •
edited

Motivation for this change

noticed it was failing on another PR

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner January 7, 2020 09:47
@FRidh
Copy link
Member

FRidh commented Jan 7, 2020

Though I had pushed this, but apparently not.

@FRidh FRidh merged commit 367085b into NixOS:master Jan 7, 2020
@jonringer jonringer deleted the bump-numexpr branch January 7, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh