Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.32.2 -> 0.33.0 #77115

Merged
merged 1 commit into from Jan 7, 2020
Merged

starship: 0.32.2 -> 0.33.0 #77115

merged 1 commit into from Jan 7, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/pddas5019i48ifhgdqvykda614by5x79-starship-0.32.2 34.1M
/nix/store/v4nbdam3w41afv0x8kc9l8f9vhbn3r78-starship-0.33.0 33.8M

Notify maintainers

cc @davidtwco @filalex77

davidtwco
davidtwco approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nix-review.

Br1ght0ne
Br1ght0ne approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested review from davidtwco and Br1ght0ne January 7, 2020 02:27
@marsam marsam merged commit f7c7317 into NixOS:master Jan 7, 2020
@bbigras bbigras deleted the starship branch January 7, 2020 12:39
@bbigras
Copy link
Contributor Author

bbigras commented Jan 7, 2020

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco Awaiting requested review from davidtwco

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @davidtwco @Br1ght0ne @marsam