Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coc-metals vim plugin #76305

Merged
merged 2 commits into from Jan 6, 2020
Merged

Add coc-metals vim plugin #76305

merged 2 commits into from Jan 6, 2020

Conversation

softinio
Copy link
Member

Motivation for this change

Add coc-metals vim plugin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer

@softinio
Copy link
Member Author

softinio commented Jan 3, 2020

@jonringer Happy new year. Sorry to chase sir, do you have time to review this PR?

@ryantm ryantm merged commit dab8500 into NixOS:master Jan 6, 2020
@softinio softinio deleted the add-coc-metals-vim-plugin branch January 6, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlovinger justinlovinger justinlovinger approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@softinio @justinlovinger @ryantm