Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scikit-build by removing no longer needed patch. #76993

Merged
merged 1 commit into from Jan 5, 2020
Merged

Fix scikit-build by removing no longer needed patch. #76993

merged 1 commit into from Jan 5, 2020

Conversation

mildlyincompetent
Copy link
Contributor

Motivation for this change

scikit-build is currently broken, as it attempts to apply a patch which was relevant for older version but is no longer required for 0.10.0.

Things done

Removed the no longer necessary patch, the failure of which was preventing the package from being built. The package now builds and does not fail any tests.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FlorianFranzen

@mildlyincompetent mildlyincompetent changed the title Remove no longer needed patch. Fix scikit-build by removing no longer needed patch. Jan 5, 2020
@mildlyincompetent
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.scikit-build python27Packages.scikit-build

@mildlyincompetent
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.scikit-build

@FRidh
Copy link
Member

FRidh commented Jan 5, 2020

@GrahamcOfBorg build python38Packages.scikit-build

@FlorianFranzen
Copy link
Contributor

@mildlyincompetent You are correct. I upstreamed the patch (scikit-build/scikit-build#385) and it was included in the release 0.9.0, so it is no longer needed. Thank you for fixing this.

@roberth roberth merged commit 0752cf0 into NixOS:master Jan 5, 2020
@mildlyincompetent mildlyincompetent deleted the fix-scikit-build branch January 5, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mildlyincompetent @FRidh @FlorianFranzen @roberth @Janik-Haag