Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: 0.5.12 -> 0.5.15 #76276

Merged
merged 1 commit into from
Jan 6, 2020
Merged

solc: 0.5.12 -> 0.5.15 #76276

merged 1 commit into from
Jan 6, 2020
+4 −82

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Dec 23, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @akru @lionello

Sorry, something went wrong.

@ofborg ofborg bot requested review from akru, lionello and sifmelcara December 23, 2019 15:41
@livnev
Copy link
Contributor

livnev commented Dec 26, 2019

Tested on nixOS, it builds and works. 👍

@asymmetric
Copy link
Contributor Author

asymmetric commented Dec 26, 2019 •
edited
Loading

@akru should we remove the dev output from

  outputs = [ "out" "dev" ];

?

EDIT: answered my own question.

@asymmetric
solc: 0.5.12 -> 0.5.15
4b45638 
Also removes patchset for shared library use, since usage of this
feature was rare and maintenance costly.
See NixOS#39852 (comment)
for a discussion.
@asymmetric
Copy link
Contributor Author

asymmetric commented Jan 3, 2020 •
edited
Loading

Is there still something to be done or can this be merged?

It introduces some changes that will be useful for future Linux versions (namely, removing a patch and building shared libraries)

@sifmelcara
Copy link
Member

LGTM 👍, built on NixOS

@asymmetric asymmetric mentioned this pull request Jan 4, 2020
Merged
1 task
@domenkozar domenkozar merged commit 1101ef4 into NixOS:master Jan 6, 2020
@asymmetric asymmetric deleted the solc-0.5.15 branch January 6, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akru akru

@lionello lionello

@sifmelcara sifmelcara

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asymmetric @livnev @sifmelcara @domenkozar