Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.git-workspace: init at 0.4.1 #77082

Merged
merged 1 commit into from
Jan 30, 2020
Merged

gitAndTools.git-workspace: init at 0.4.1 #77082

merged 1 commit into from
Jan 30, 2020
+35 −0

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jan 6, 2020 •
edited
Loading

Motivation for this change

https://github.com/orf/git-workspace/releases/tag/v0.4.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Br1ght0ne
Br1ght0ne approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable shows usage

[5 built, 3 copied (143.6 MiB), 35.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77082
1 package built:
git-workspace

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 6, 2020
@teto
Copy link
Member

teto commented Jan 9, 2020

I would rather see it in pkgs/applications/version-management/git-and-tools/default.nix

@misuzu misuzu force-pushed the git-workspace-init branch from d22d1cf to 19a6cd3 Compare January 9, 2020 16:08
@misuzu
Copy link
Contributor Author

misuzu commented Jan 9, 2020

Moved to pkgs/applications/version-management/git-and-tools

@teto
Copy link
Member

teto commented Jan 9, 2020

@GrahamcOfBorg build gitAndTools.git-workspace

@misuzu misuzu requested a review from worldofpeace January 28, 2020 20:35
worldofpeace
worldofpeace suggested changes Jan 30, 2020
View reviewed changes
pkgs/applications/version-management/git-and-tools/git-workspace/default.nix Outdated
Comment on lines 1 to 31
{ stdenv, fetchFromGitHub, rustPlatform, Security }:
rustPlatform.buildRustPackage rec {
pname = "git-workspace";
version = "0.4.1";
src = fetchFromGitHub {
owner = "orf";
repo = pname;
rev = "v${version}";
sha256 = "01qxm00c5wqpy1clrvjr44v7cg4nqawaf5a6qnvvgswvis4kakzr";
};
cargoSha256 = "16rkmk888alfvq8nsggi26vck1c7ya0fa5j7gv219g5py4gw2n34";
verifyCargoDeps = true;
buildInputs = with stdenv; lib.optional isDarwin Security;
meta = with stdenv.lib; {
description = "Sync personal and work git repositories from multiple providers";
homepage = src.meta.homepage;
license = with licenses; [ mit ];
platforms = platforms.all;
maintainers = with maintainers; [ misuzu ];
};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expression lacks any proper whitespace, see https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/pantheon/granite/default.nix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expression lacks any proper whitespace, see https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/pantheon/granite/default.nix

Will do.
Is there some kind of style guide? nixfmt says that everything is fine as it is now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there isn't. And I think nixfmt is more for formatting nix code and not nixpkgs, and in growing popularity https://github.com/nix-community/nixpkgs-fmt. But I can ask many many of the core body that expressions without whitespace separating attributes is pretty ugly.

I'm not sure if the coding conventions mentions this https://nixos.org/nixpkgs/manual/#chap-conventions, but a cursory look at nixpkgs hopefully reveals this (recent expressions).

@worldofpeace
Copy link
Contributor

@misuzu you need to change your commit message to start with the attr gitAndTools.git-workspace

@misuzu misuzu force-pushed the git-workspace-init branch from 19a6cd3 to 9c2e01d Compare January 30, 2020 00:35
@misuzu misuzu changed the title git-workspace: init at 0.4.1 gitAndTools.git-workspace: init at 0.4.1 Jan 30, 2020
@worldofpeace
Copy link
Contributor

Building it now, but it's probably good and will merge.

@misuzu misuzu force-pushed the git-workspace-init branch from 9c2e01d to b81d1b1 Compare January 30, 2020 08:34
@worldofpeace worldofpeace merged commit 183e706 into NixOS:master Jan 30, 2020
@worldofpeace
Copy link
Contributor

Thanks for contributing @misuzu ✨

anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#77082 from misuzu/git-workspace-init
f9cf549 
gitAndTools.git-workspace: init at 0.4.1
@misuzu misuzu deleted the git-workspace-init branch April 22, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@Br1ght0ne Br1ght0ne

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@misuzu @teto @worldofpeace @Br1ght0ne