Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anarchism: init at 15.3-1 #77009

Merged
merged 1 commit into from Aug 20, 2020
Merged

anarchism: init at 15.3-1 #77009

merged 1 commit into from Aug 20, 2020

Conversation

davidak
Copy link
Member

@davidak davidak commented Jan 6, 2020

Motivation for this change

I talked to someone about NixOS at the 36C3 and we discovered that this package is missing.

It is a FAQ about anarchism that was originally packaged for debian and can be found in many debian derivations and AUR. https://repology.org/project/anarchism/versions

Ever wanted to install anarchism on your system? Now you can also on NixOS!

It includes HTML and Markdown files, an icon and desktop file. So you can open it in your browser from the menu.

Screenshot from 2020-01-06 05-47-23

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak davidak changed the title anarchism: init at 15.1-11 anarchism: init at 15.3-1 Jan 11, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/108

@danieldk
Copy link
Contributor

danieldk commented Jan 26, 2020 •
edited

I have always found it strange that Debian packages this. Can't someone just browse the website?

(Just wondering where the boundary is of packaging websites that are under a free license. If this does fit nixpkgs, the C++ Annotations would be another good candidate.)

@davidak
Copy link
Member Author

davidak commented Jan 26, 2020

I have always found it strange that Debian packages this. Can't someone just browse the website?

Good point. It's probably intended for offline use. When the system crashes (and the internet is down) you might remember that anarchism can help to organize groups and want to study it.

Same can apply for the NixOS manual or man pages. I actually never used the installed manual.

If this does fit nixpkgs, the C++ Annotations would be another good candidate.

I don't think we have rules for that, so it's a topic that can be discussed. It falls under the category documentation. I think if it's useful and people would use it, just package it.

It seems to exists only as debian package (and derivations): https://repology.org/project/c%2B%2B-annotations/versions

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/package-static-content-like-website/6149/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/250

@davidak
Copy link
Member Author

davidak commented Aug 9, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Aug 9, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 9, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@bbigras
Copy link
Contributor

bbigras commented Aug 10, 2020

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

the .desktop file seems to work fine.

@davidak davidak mentioned this pull request Aug 10, 2020
Open
@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 19, 2020

@glittershark please review.

@bbigras
Copy link
Contributor

bbigras commented Aug 20, 2020

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau August 20, 2020 00:11
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/204

timokau
timokau approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a fun example and shouldn't really add any noticeable maintenance burden. Thanks!

@timokau timokau merged commit 5cc57fe into NixOS:master Aug 20, 2020
@davidak davidak deleted the anarchism branch August 22, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras bbigras approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidak @nixos-discourse @danieldk @bbigras @timokau