Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libev: Add statically linked libev to pkgsStatic #77180

Merged
merged 1 commit into from Jan 10, 2020
Merged

libev: Add statically linked libev to pkgsStatic #77180

merged 1 commit into from Jan 10, 2020

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Jan 7, 2020 •
edited

Motivation for this change

I have a use case for compiling a fully static binary with libev. I added this my project and it worked nicely.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @r-ryantm

anmonteiro added a commit to nix-ocaml/nix-overlays that referenced this pull request Jan 7, 2020
@anmonteiro
Static libev
0dc59be 
while NixOS/nixpkgs#77180 isn't merged
@anmonteiro
Copy link
Member Author

Could I get a review please? Tagging more folks from the commit history: @wkennington @fpletz @joachifm

@ryantm
Copy link
Member

ryantm commented Jan 10, 2020

@GrahamcOfBorg build pkgsStatic.libev

ryantm
ryantm approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it isn't building on Darwin, but this seems like a good enough start.

@ryantm ryantm merged commit 55adc49 into NixOS:master Jan 10, 2020
@anmonteiro
Copy link
Member Author

Thanks. I haven't managed to cross compile on macOS yet. Last time I tried it failed to build the toolchain.

I could've done something wrong too. I'll try again soon.

@anmonteiro anmonteiro deleted the anmonteiro/libev-static branch January 10, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
6.topic: static 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anmonteiro @ryantm @veprbl