Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profile-sync-daemon: fix psd-overlay-helper paths #76998

Merged
merged 1 commit into from Apr 24, 2020
Merged

profile-sync-daemon: fix psd-overlay-helper paths #76998

merged 1 commit into from Apr 24, 2020

Conversation

jflanglois
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @prikhi

@jflanglois
profile-sync-daemon: fix psd-overlay-helper paths
0dd0d03 
The installPhase for profile-sync-daemon does not properly replace
all binary invocations in psd-overlay-help. This fixes it.
@NickHu
Copy link
Contributor

NickHu commented Feb 17, 2020

Could you please write up why this change was necessary, just for the record?

@jflanglois
Copy link
Contributor Author

jflanglois commented Feb 19, 2020 •
edited

@NickHu Yes of course. Essentially one cannot use overlayfs mode Without this change because the helper binary will just fail without available sudo and stat commands.

@jflanglois
Copy link
Contributor Author

@NickHu are we good to go merging this?

@NickHu
Copy link
Contributor

NickHu commented Apr 16, 2020

@jflanglois I marked these changes as approved months ago, but I don't have the authority to merge. I'll ping someone in the IRC

@obadz obadz merged commit ea9b5c5 into NixOS:master Apr 24, 2020
@jflanglois jflanglois deleted the fix-psd-overlay-helper branch June 5, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickHu NickHu NickHu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jflanglois @NickHu @obadz