Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicity: 0.7.19 -> 0.8.10, use python3 #76988

Merged
merged 1 commit into from Feb 11, 2020
Merged

duplicity: 0.7.19 -> 0.8.10, use python3 #76988

merged 1 commit into from Feb 11, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh FRidh added this to WIP in Python 2 deprecation Jan 5, 2020
@ofborg ofborg bot removed the 6.topic: python label Jan 5, 2020
@ofborg ofborg bot requested a review from peti January 5, 2020 16:51
@jtojnar
Copy link
Contributor

jtojnar commented Jan 6, 2020

Note that 0.8 is still a dev version.

@Frostman
Copy link
Member

Frostman commented Feb 8, 2020 •
edited

There is 0.8.10 was released January 23, 2020 and it's considered as current stable per https://www.nongnu.org/duplicity

@jtojnar jtojnar added this to the 20.03 milestone Feb 8, 2020
@jtojnar jtojnar self-assigned this Feb 10, 2020
@FRidh @jtojnar
duplicity: 0.7.19 -> 0.8.10
b512693 
Update, port to Python 3 and clean up.

Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
Co-Authored-By: Frederik Rietdijk <fridh@fridh.nl>
jtojnar
jtojnar approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified duplicity working in deja-dup.

@FRidh FRidh changed the title WIP: duplicity: 0.7.19 -> 0.8.08, use python3 duplicity: 0.7.19 -> 0.8.10, use python3 Feb 10, 2020
FRidh
FRidh commented Feb 10, 2020
View reviewed changes
Copy link
Member Author

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, but I haven't tested it.

@jtojnar jtojnar removed this from the 20.03 milestone Feb 10, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Feb 10, 2020

Let’s merge this after the branch-off, then.

@FRidh
Copy link
Member Author

FRidh commented Feb 10, 2020

This may also need a release note considering the potential risk.

@jtojnar jtojnar removed their assignment Feb 10, 2020
@jtojnar jtojnar merged commit c3a6844 into NixOS:master Feb 11, 2020
Python 2 deprecation automation moved this from WIP to Done Feb 11, 2020
@jtojnar jtojnar mentioned this pull request Feb 11, 2020
Closed
10 tasks
@despresc despresc mentioned this pull request Feb 21, 2020
Closed
@FRidh FRidh deleted the duplicity branch March 15, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
Python 2 deprecation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @jtojnar @Frostman