Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python: gym: 0.15.3 -> 0.15.4" #77049

Closed
wants to merge 2 commits into from
Closed

Revert "python: gym: 0.15.3 -> 0.15.4" #77049

wants to merge 2 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020 •
edited

Motivation for this change

noticed it was broken, froze/renamed it to prevent accidental bumpage

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

failures broken on master

[6 built (8 failed), 116 copied (608.5 MiB), 83.3 MiB DL]
error: build of '/nix/store/8jaxndxgs52ymddx8ac66333gygmlyd4-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77049
4 package failed to build:
python37Packages.baselines python37Packages.rl-coach python38Packages.baselines python38Packages.rl-coach

5 package built:
python27Packages.gym python37Packages.gym python37Packages.roboschool python38Packages.gym python38Packages.roboschool

@jonringer jonringer requested a review from FRidh as a code owner January 6, 2020 11:15
@jonringer
python3Packages.gym: freeze at 0.15.3.nix
3798a2d 
to prevent accidental bumpage
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.gym python37Packages.gym python37Packages.roboschool python38Packages.gym python38Packages.roboschool

@FRidh
Copy link
Member

FRidh commented Jan 6, 2020 via email

@jonringer
Copy link
Contributor Author

This is intended to prevent the pypi update script from targeting this. Even with an assert, this file will be updated. The other option would be to do FetchFromGitHub

@FRidh
Copy link
Member

FRidh commented Jan 6, 2020

Yes but it would fail on eval, that way it would be clear. When updating I often take all nix files, so this would not help.

@jonringer
Copy link
Contributor Author

the file may be passed to the update script, but the update script skips files which has fetchFromGitHub in it:

nixpkgs/pkgs/development/interpreters/python/update-python-libraries/update-python-libraries.py

Line 242 in 15695df

elif fetcher == 'fetchFromGitHub':

@jonringer
Copy link
Contributor Author

bump @FRidh

what do you think about using fetchFromGitHub?

@juliendehos juliendehos mentioned this pull request Feb 13, 2020
Merged
@jonringer
Copy link
Contributor Author

update in #80024 makes this unnecessary

@jonringer jonringer closed this Feb 13, 2020
@jonringer jonringer deleted the fix-gym branch February 13, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh