Signal: allow to use integral Enum for reset value. #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Jan 6, 2020
nmigen/hdl/ast.py
Outdated
| @@ -834,6 +834,11 @@ def __init__(self, shape=None, *, name=None, reset=0, reset_less=False, min=None | |||
| attrs=None, decoder=None, src_loc_at=0): | |||
| super().__init__(src_loc_at=src_loc_at) | |||
|
|
|||
| if isinstance(reset, Enum): | |||
| reset = reset.value | |||
| if not type(reset) == int: | |||
There was a problem hiding this comment.
This should be an isinstance(reset, int), or reset=True will fail. (bool is derived from int in Python.)
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 82.13% 82.13% -0.01%
==========================================
Files 34 34
Lines 5647 5652 +5
Branches 1160 1162 +2
==========================================
+ Hits 4638 4642 +4
- Misses 864 865 +1
Partials 145 145
Continue to review full report at Codecov.
|
whitequark
reviewed
Jan 6, 2020
|
Thanks. Could you add a test as well? |
|
Pushed a test. |
|
Pushed change that removes reference to bool in docstring and extended test to check for non-integral Enum type. |
whitequark
reviewed
Jan 9, 2020
|
|
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #294.