New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #77047
Merged
Merged
Staging next #77047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in 6449435, only Python 2 is supported and it does not seem to be used by anything.
Also remove no longer needed perl.
Nothing much seems to be using it and we do not want Python 2 in our closure.
It does not seem to be used by anything and we want to get rid of Python 2 from closure.
For some reason we depended on both.
It does not appear to be actually necessary – wafHook will add it.
Nothing seems to use the Python bindings anyway.
Static libraries are to be provided by the pkgsStatic.fmt package.
pkgsStatic.gtest already has CMAKE_BUILD_SHARED set to OFF.
pkgsStatic.glog already has CMAKE_BUILD_SHARED set to OFF.
pkgsStatic.double-conversion already has CMAKE_BUILD_SHARED set to OFF.
Apple no longer ships with it, so best to avoid forcing it into use.
Even when building for the simulator.
libtool is not really needed and it interferes with updateAutotoolsGnuConfigScriptsHook. So remove it when cross-compiling, but leave it in native to preserve hashes.
Update iOS for XCode 11
The nss rebuild isn't so small.
This is going to require more work. This reverts commit 2dc4ab3.
just curious? what made you back off python38? major issues i could think of are aiohttp and one other ... I can't remember right now |
apparmor still partially fails and with it a lot of other packages, so that's why I reverted it for now |
10 tasks
tobim
suggested changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @