Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plex: 1.18.3.2156 -> 1.18.4.2171 #77162

Merged
merged 1 commit into from Jan 7, 2020
Merged

plex: 1.18.3.2156 -> 1.18.4.2171 #77162

merged 1 commit into from Jan 7, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/4ad0pssmsl5597s4g65vazr3ijcbg9px-plexmediaserver 516.5M
/nix/store/x6xhnvlb1w9xjjk2c9rj5b90pqmw8p9d-plexmediaserver 515.8M

Notify maintainers

cc @colemickens @Forkk @LnL7 @pjones @thoughtpolice

@colemickens
Copy link
Member

LGTM, works for me here.

@LnL7 LnL7 merged commit 1acf261 into NixOS:master Jan 7, 2020
@bbigras bbigras deleted the plex branch January 7, 2020 12:43
@bbigras
Copy link
Contributor Author

bbigras commented Jan 7, 2020

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants