Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samurai: init at 1.0 #77140

Merged
merged 1 commit into from Feb 13, 2020
Merged

samurai: init at 1.0 #77140

merged 1 commit into from Feb 13, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 6, 2020

Motivation for this change

samurai is a ninja-compatible build tool written in C99 with a focus on
simplicity, speed, and portability.

Will need some plumbing work to be used automagically in nixpkgs like we
do with ninja (setup-hook to start), but still nice to have packaged for
anyone interested in using now that 1.0 has been released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 6, 2020

Notes in case folks are interested/find it useful:

Possible issues preventing replacing ninja w/samu (regardless of whether that's desired, not here to tackle that):

When used with meson, may want to disable terminal escapes (color diagnostics), see README.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 6, 2020

(added homepage to meta, whoops)

@dtzWill
Copy link
Member Author

dtzWill commented Feb 13, 2020

With some patches in recent git, compdb is added! Leaving for a separate PR, but if anyone is interested I've put together needed bits to use samu for build instead of ninja (various motivations, but especially interesting for much reduced dep tree (notably no python needed-- which for nixpkgs might be useful for slimmer bootstrapping):

Anyway, for the curious/interested: https://github.com/dtzWill/nixpkgs/tree/experimental/samurai-setup-hook .

@dtzWill dtzWill merged commit 18d9cc2 into NixOS:master Feb 13, 2020
@dtzWill dtzWill deleted the feature/samurai branch February 13, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @nh2