Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4350bb89d3b8
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aa27f3cfc9e5
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Jan 5, 2020

  1. Upgrade to 16.4.2.

    pleroy committed Jan 5, 2020
    Copy the full SHA
    6c6df1e View commit details
  2. Fix coverage path.

    pleroy committed Jan 5, 2020
    Copy the full SHA
    0865fac View commit details
  3. Merge pull request #2433 from pleroy/16.4.2

    Upgrade to Visual Studio 2019 16.4.2
    pleroy authored Jan 5, 2020
    Copy the full SHA
    aa27f3c View commit details
Showing with 4 additions and 3 deletions.
  1. +2 −1 base/not_null_test.cpp
  2. +1 −1 find_msbuild.ps1
  3. +1 −1 parallel_test_runner/parallel_test_runner.cs
3 changes: 2 additions & 1 deletion base/not_null_test.cpp
Original file line number Diff line number Diff line change
@@ -63,7 +63,8 @@ TEST_F(NotNullTest, Move) {
_MSC_FULL_VER == 192'227'706 || \
_MSC_FULL_VER == 192'227'724 || \
_MSC_FULL_VER == 192'227'905 || \
_MSC_FULL_VER == 192'328'106)
_MSC_FULL_VER == 192'328'106 || \
_MSC_FULL_VER == 192'428'314)
EXPECT_THAT(*(std::unique_ptr<int> const&)int_ptr1, Eq(3));
#endif
not_null<std::unique_ptr<int>> int_ptr2 = std::move(int_ptr1);
2 changes: 1 addition & 1 deletion find_msbuild.ps1
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$version = "16.3.8"
$version = "16.4.2"
$preview = ""
if ($preview.length -gt 0) {
$description = "version $version preview $preview"
2 changes: 1 addition & 1 deletion parallel_test_runner/parallel_test_runner.cs
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ private static T ParseEnum<T>(string value) {
}

private const string vsinstr =
@"C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\" +
@"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\" +
@"Team Tools\Performance Tools\x64\vsinstr.exe";

static Task RunProcessAsync(string file_name, string args) {