Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mysql: restart systemd service on abort #77158

Merged
merged 1 commit into from Jan 9, 2020
Merged

nixos/mysql: restart systemd service on abort #77158

merged 1 commit into from Jan 9, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 7, 2020 •
edited

Motivation for this change

One of my mariadb instances crashed and never restarted. Took these values from Debian 9 as they seemed reasonable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse requested a review from danbst January 7, 2020 01:11
@aanderse
Copy link
Member Author

aanderse commented Jan 7, 2020

@GrahamcOfBorg test mysql

@aanderse aanderse requested a review from flokli January 8, 2020 19:09
@flokli
Copy link
Contributor

flokli commented Jan 9, 2020

LGTM. Restart=on-abnormal is already set by upstream mariadb:
https://github.com/MariaDB/server/blob/10.5/support-files/mariadb.service.in

I assume (non-mariadb) mysql behaves similar enough when it's crashing.

@flokli flokli merged commit 5a523d7 into NixOS:master Jan 9, 2020
@aanderse aanderse deleted the mysql branch January 9, 2020 16:21
@aanderse
Copy link
Member Author

aanderse commented Jan 9, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst Awaiting requested review from danbst

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @flokli