Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keras 2.3.1 backport to 19.09 #77040

Closed
wants to merge 1 commit into from
Closed

Keras 2.3.1 backport to 19.09 #77040

wants to merge 1 commit into from

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Jan 6, 2020 •
edited

Motivation for this change

19.09 Keras 2.2.4 is not compatible with Tensorflow 1.14 due to multi-gpu
Fixes: #72799

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @CMCDragonkai

@Rakesh4G Rakesh4G requested a review from FRidh as a code owner January 6, 2020 10:40
@CMCDragonkai
Copy link
Member

@NikolaMandic

@veprbl
Copy link
Member

veprbl commented Mar 30, 2020

@GrahamcOfBorg build python27Packages.Keras
@GrahamcOfBorg build python37Packages.Keras

@veprbl
Copy link
Member

veprbl commented Mar 30, 2020

The 20.03 should be coming out very soon. I think we could merge this, but I have one concern: it is whether with this bump we might break something unrelated to the multi-gpu backend.

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Mar 30, 2020 •
edited

We were using it with no problems. But now w moved to keras native inside tf.

@veprbl
Copy link
Member

veprbl commented Mar 31, 2020

@CMCDragonkai So, can we close this without merge?

@Mic92
Copy link
Member

Mic92 commented Jun 18, 2020

Now 20.03 is here to be, we can close this one.

@Mic92 Mic92 closed this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rakesh4G @CMCDragonkai @veprbl @Mic92