Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.mypy: 0.750 -> 0.761 #77039

Merged
merged 1 commit into from Jan 6, 2020
Merged

python3Packages.mypy: 0.750 -> 0.761 #77039

merged 1 commit into from Jan 6, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020 •
edited

Motivation for this change

noticed it was out of date @r-ryantm in logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

failures are broken on master

[16 built (3 failed), 279 copied (432.5 MiB), 60.1 MiB DL]
error: build of '/nix/store/dcwri69x5ialm1b4cfsy65xjwq7bphmd-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77039
3 package failed to build:
python38Packages.git-revise python38Packages.ics python38Packages.pyls-mypy

16 package built:
git-revise mypy nix-pin python37Packages.algebraic-data-types python37Packages.ics python37Packages.pyls-mypy python37Packages.pynamodb python37Packages.pytest-mypy python37Packages.tatsu python38Packages.algebraic-data-types python38Packages.mypy python38Packages.pynamodb python38Packages.pytest-mypy python38Packages.tatsu thonny zfs-replicate
```

@jonringer jonringer requested a review from FRidh as a code owner January 6, 2020 10:37
@lsix
Copy link
Member

lsix commented Jan 6, 2020

nix-review gives mi more errors here:

5 package failed to build:
python37Packages.algebraic-data-types python38Packages.algebraic-data-types python38Packages.git-revise python38Packages.ics python38Packages.pyls-mypy

14 package built:
git-revise mypy nix-pin python37Packages.ics python37Packages.pyls-mypy python37Packages.pynamodb python37Packages.pytest-mypy python37Packages.tatsu python38Packages.mypy python38Packages.pynamodb python38Packages.pytest-mypy python38Packages.tatsu thonny zfs-replicate

🤔

@jonringer
Copy link
Contributor Author

odd, im able to build it fine

[02:59:34] jon@jon-desktop /home/jon/projects/nixpkgs (bump-mypy)
$ nix-build -A python3Packages.algebraic-data-types
/nix/store/6qi91xpzjw6wkxb0lcws0s8rlq2csm66-python3.7-algebraic-data-types-0.1.1

@lsix
Copy link
Member

lsix commented Jan 6, 2020

I guess this was because my master was lagging a bit behing. After a proper pull, I get the same 3 build failed.

All good to me then. I have built and tested it.

I’ll merge.

@lsix lsix merged commit cc62409 into NixOS:master Jan 6, 2020
@lsix
Copy link
Member

lsix commented Jan 6, 2020

And of course thanks for the work ;)

@jonringer jonringer deleted the bump-mypy branch January 6, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @lsix