Town, station and industry directory window sorting performance improvements #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGRennison
changed the title
glx22
reviewed
Jan 7, 2020
LordAro
reviewed
Jan 7, 2020
JGRennison
force-pushed
the
directory-list-window-sort-perf-improvements
branch
from
9716e42
to
d1b8c3f
Compare
LordAro
requested changes
Jan 8, 2020
…sorting This is to avoid needing to expensively regenerate name strings on every comparison when sorting by name in the town/station/industry list windows.
JGRennison
force-pushed
the
directory-list-window-sort-perf-improvements
branch
from
d1b8c3f
to
7394549
Compare
LordAro
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary resorts of the town and industry directory windows due to population and production changes respectively, when the current sort mode does not depend on the town population or industry production.
Avoid regenerating town, station and industry name strings on every sort comparison and on every town name filter.
Measurements of the time taken to sort the town directory window on a 4k x 4k map indicated a reduction in sort time of between 7.5x and 11x.