Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bandwhich: 0.6.0 -> 0.7.0 #77028

Merged
merged 1 commit into from Jan 6, 2020
Merged

bandwhich: 0.6.0 -> 0.7.0 #77028

merged 1 commit into from Jan 6, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Jan 6, 2020 •
edited

Motivation for this change

https://github.com/imsnif/bandwhich/releases/tag/0.7.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

stigtsp
stigtsp approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Note: It appears not to be working with wireguard interfaces.

Result of nixpkgs-review pr 77028 1

1 package built:
  • bandwhich

@markuskowa
Copy link
Member

@GrahamcOfBorg build bandwhich

@markuskowa markuskowa merged commit 5f5c704 into NixOS:master Jan 6, 2020
@Br1ght0ne Br1ght0ne deleted the bandwhich-0.7.0 branch January 6, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @markuskowa @stigtsp