Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules: boot.extraTTYs to console.extraTTYs #76182

Closed
wants to merge 2 commits into from
Closed

modules: boot.extraTTYs to console.extraTTYs #76182

wants to merge 2 commits into from

Conversation

alexarice
Copy link
Contributor

Motivation for this change

A recent change changed an option name and I think these modules should have this module changed as well.

Things done

Changed boot.extraTTYs to console.extraTTYs in the nixos manual module and rogue module.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rnhmjoj as I believe you made the console change

@alexarice alexarice changed the title Extratty modules: boot.extraTTYs to console.extraTTYs Dec 22, 2019
rnhmjoj
rnhmjoj approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right: I forgot to rename existing options. Thank you.

@infinisil
Copy link
Member

Thanks! Unfortunately this kind of drowned in the sea of open PR's such that another one fixed it instead: #76852, I shall remind @lovesegfault to use the search function :)

@infinisil infinisil closed this Jan 7, 2020
@lovesegfault
Copy link
Member

@infinisil My bad, this was one of a handful PR's opened/closed quickly in a fixing spree with Graham :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@kylesferrazza kylesferrazza kylesferrazza approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexarice @infinisil @lovesegfault @rnhmjoj @kylesferrazza