Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: Apply a IndexDB Patch #77126

Closed
wants to merge 1 commit into from
Closed

firefox: Apply a IndexDB Patch #77126

wants to merge 1 commit into from

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Jan 6, 2020

I tried the fix from https://bugzilla.mozilla.org/show_bug.cgi?id=1601707
but it didn‘t solve my problem element-hq/element-web#11711

Therefore I instead applied
https://salsa.debian.org/mozilla-team/firefox/commit/e888ce1578d68116949782035f8149cdbc5e832c

which is supposedly a patch for the same problem.

I admit I don‘t know why this helps. I just tried it out because I
heard that the bug does not exist under debian.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andir

@maralorn maralorn mentioned this pull request Jan 6, 2020
Closed
@ofborg ofborg bot requested review from andir and edolstra January 7, 2020 03:34
@lheckemann
Copy link
Member

IIUC this bug is fixed in 72.0, which was released today? In that case, it makes sense to just bump firefox and not apply this patch.

@andir
Copy link
Member

andir commented Jan 7, 2020

IIUC this bug is fixed in 72.0, which was released today? In that case, it makes sense to just bump firefox and not apply this patch.

It wasn't fixed in 72.. the upstream bug is ... complicated ...

@maralorn
Copy link
Member Author

maralorn commented Jan 7, 2020

I have now used a patch provided by mozilla instead of the one from debian. This is apparently applied in firefox 74, so this is just a backport of an upstream fix.

@maralorn maralorn changed the title firefox: Apply a IndexDB Patch from debian firefox: Apply a IndexDB Patch Jan 7, 2020
@maralorn
Copy link
Member Author

maralorn commented Jan 7, 2020

Fixes #76899

@Ma27 Ma27 requested a review from fpletz January 7, 2020 19:48
Ma27
Ma27 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built this ff locally and everything seems fine 👍

@maralorn
Copy link
Member Author

maralorn commented Jan 8, 2020

This PR is superseeded by #77292 so I think we shouldn‘t invest anymore time in it.

@maralorn maralorn closed this Jan 8, 2020
@maralorn maralorn deleted the fix-firefox branch January 8, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@andir andir Awaiting requested review from andir

@edolstra edolstra Awaiting requested review from edolstra

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maralorn @lheckemann @andir @Ma27