Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: 14.2.4 -> 14.2.5 #77167

Merged
merged 2 commits into from Jan 9, 2020
Merged

ceph: 14.2.4 -> 14.2.5 #77167

merged 2 commits into from Jan 9, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jan 7, 2020 •
edited

Motivation for this change

Fixes a critical integrity bug n 14.2.3 and 14.2.4. Adds newly required deps on libnl and libcap_ng.

This needs backporting to 19.09, but I think we should also backport the various fixes to rocksdb etc. before doing so. I can author that.

WIP while my poor laptop chugs away at building it...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@srhb srhb requested review from lejonet and flokli January 7, 2020 06:58
@srhb
Copy link
Contributor Author

srhb commented Jan 7, 2020

Ready for review. I'll hopefully be able to deploy this to a test cluster soonish, but I think it's good from testing in VMs.

There's a critical bug in the current 14.2.4 version which may cause OSD corruption when bluestore WALs are on separate devices.
There are other, smaller changes to deps and behaviour (specifically more health checks) that required tests to be tuned slightly.

Note that the multi node test currently fails because of a regression in the python test suite which causes files to no longer be shared among VMs in /tmp/shared. Reverting ef5bc38 causes the ceph test to succeed, so I think we're good from this side.

@srhb
Copy link
Contributor Author

srhb commented Jan 7, 2020

Oh, and I'll probably set up a full backport of floklis fixes to ceph/rocksdb and this, if this passes review, since we really need to get this version in stable as well, and the changes should be safe. :)

@flokli
Copy link
Contributor

flokli commented Jan 7, 2020

cc @7c6f434c w.r.t /tmp/shared.

@ofborg ofborg bot added the 6.topic: nixos label Jan 7, 2020
@ofborg ofborg bot requested review from krav, adevress and johanot January 7, 2020 09:06
@7c6f434c
Copy link
Member

7c6f434c commented Jan 8, 2020

Hm, maybe we should split the shared reference into internal_shared and external_shared then?

lejonet
lejonet approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@lejonet lejonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really see anything wrong with the changes. Thumbs up from me!

@flokli flokli merged commit 2603d15 into NixOS:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@lejonet lejonet lejonet approved these changes

@krav krav Awaiting requested review from krav

@adevress adevress Awaiting requested review from adevress

@johanot johanot Awaiting requested review from johanot

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srhb @flokli @7c6f434c @lejonet