Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.annoy: add missing h5py dependency #77036

Merged
merged 1 commit into from Jan 6, 2020
Merged

python3Packages.annoy: add missing h5py dependency #77036

merged 1 commit into from Jan 6, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020 •
edited

Motivation for this change

noticed it was broken reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner January 6, 2020 09:49
@Br1ght0ne
Copy link
Member

@GrahamcOfBorg build python3Packages.annoy

@ofborg ofborg bot requested a review from timokau January 6, 2020 11:41
@timokau
Copy link
Member

timokau commented Jan 6, 2020

@GrahamcOfBorg build python3.pkgs.rl-coach

timokau
timokau approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time for a thorough review right now, but it definitely can't make things worse form the current build failure.

@jonringer
Copy link
Contributor Author

tensorflow build is broken right now, so rl-coach will fail anyway

@jonringer jonringer merged commit e8f0c89 into NixOS:master Jan 6, 2020
@jonringer jonringer deleted the fix-annoy branch January 6, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @Br1ght0ne @timokau @FRidh