-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/systemd: Explicitly put default path packages after othe… #77088
Conversation
This fixes the dhcpcd issue in NixOS#76969, which was exposed by NixOS#75031 introducing changes in the module ordering and therefore option ordering too. The dhcpcd issue would also be fixable by explicitly putting dhcpcd's paths before others, however it makes more sense for systemd's default paths to be after all others by default, since they should only be a fallback, which is how binary finding will work if they come after.
All the time has this caused an issue for me 👍 |
Not sure why ofborg doesn't start eval, trying manually.. @GrahamcOfBorg eval Edit: Nope! |
@infinisil ofborg hasn't made its 2020 comeback yet? |
I asked graham what's up with that in #nixos-borg, haven't heard back yet |
Intersting: this already happened once: #55886 (comment). I fixed it by lowering the priority of systemd (d16a243). I'm not sure why it happened last year. Also, do you know why/how did your PR affect priorities? |
@rnhmjoj Ah that's something slightly different: In that case systemd and openresolv are installed into a single environment with In this case however we have |
@infinisil Ah, I see. Thank you for the explanation. |
It fixes #76969 for me 👍 |
Alright let's just merge even without the bot, what could go wrong with such a simple change! (famous last words..) |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/lib-types-anythings-merge-function-behavior-regarding-lists/51708/8 |
Motivation for this change
This fixes the dhcpcd issue in #76969, which was exposed by #75031 introducing changes in the module ordering and therefore option ordering too.
The dhcpcd issue would also be fixable by explicitly putting
dhcpcd's paths before others, however it makes more sense for systemd's
default paths to be after all others by default, since they should only
be a fallback, which is how binary finding will work if they come after.
Ping @demokritos @izuk @karolchmist
Things done
cat /etc/resolv.conf
)