-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed system #2435
Closed system #2435
Conversation
physics/closed_system.hpp
Outdated
// Effectively an extension of | ||
// |BarycentreCalculator<DegreesOfFreedom<InertialFrame>, Mass>| that also | ||
// handles rotational motion. | ||
// Note: As a consequence of our separate handling of vectors and bivectors, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that you have to explain the gory details of the representation is a clear indication that the form is not the right level of abstraction. This is exactly where InertiaTensor
(or a simplified version thereof) would come handy. With the current API there is no abstraction to help diagonalize the tensor to obtain the principal moments and axes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, this abstraction is SymmetricBilinearForm
: a symmetric bilinear form over V is only a symmetric bilinear form over V∧V via the anticommutator, and it is obvious in higher dimensions that multiplying a bilinear form over V with an element of V∧V is nonsensical.
I has eigenvalues over V that are not the same as those of {I, _} over V∧V (but the eigenbases are consistent under ∧).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LG, but left one question.
No description provided.