Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xidlehook: 0.7.1 -> 0.8.0 #73962

Merged
merged 1 commit into from Nov 24, 2019
Merged

xidlehook: 0.7.1 -> 0.8.0 #73962

merged 1 commit into from Nov 24, 2019

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

Just a version update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jD91mZM2

Copy link
Member

@jD91mZM2 jD91mZM2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this means rust 1.39 is now in nixpkgs, cool! As there's nowadays a crate2nix file bundled along with xidlehook, I think we could spare some of that hydra server's poor resources and potentially maintainer efforts by copying the default.nix available there. See how I did for powerline-rs in #71976 :)

@d-goldin
Copy link
Contributor Author

d-goldin commented Nov 23, 2019

I briefly tried it, but crate2nix 0.6.0 struggles a little bit with this one and generates a few broken target attributes and also attempts to rename libpulse (-l pulse::libpulse.so.0) which causes further failures (at least for me). It's surely worthwhile to figure out the causes of these issues and improve crate2nix and eventually switch the build, but that would take more time.

@jD91mZM2
Copy link
Member

@d-goldin I'm talking about re-using the Cargo.nix here. That said, I forgot that disables a bunch of feature flags to avoid some errors, so you're right.

@Ma27
Copy link
Member

Ma27 commented Nov 24, 2019

In that case we'd need to incorporate Cargo.nix into nixpkgs, otherwise we'd import-from-derivation is needed to build this package which is not enabled on Hydra.

@Ma27 Ma27 merged commit 96185c3 into NixOS:master Nov 24, 2019
@d-goldin d-goldin deleted the bump_xidlehook branch November 24, 2019 11:48
@d-goldin
Copy link
Contributor Author

Thanks.

@Ma27: I think @jD91mZM2 did mean copying it to nixpkgs like it was done in the other PR referenced in an earlier comment. I on the other hand was looking at maintainability in the sense of crate2nix being able to generate working expressions (otherwise, it seems like a hassle to fiddle with those manually). In an ideal case it would just work out of the box and no manual modifications need to be carried over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants