Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rainloop-standard: Fix pname and license #73963

Merged
merged 1 commit into from Nov 23, 2019
Merged

rainloop-standard: Fix pname and license #73963

merged 1 commit into from Nov 23, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 23, 2019

  • Switched to pname
  • Fixed the double dash in pname
  • Changed license to unfree (they don't allow redistribution)

Fixes #73956

Motivation for this change

Fixes #73956

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @c0bw3b

@dasJ
rainloop-standard: Fix pname and license
b2e85c6 
- Switched to pname
- Fixed the double dash in pname
- Changed license to unfree (they don't allow redistribution)

Fixes NixOS#73956
c0bw3b
c0bw3b approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Result of nix-review pr 73963 1

2 package were build:
  • rainloop-community
  • rainloop-standard

@c0bw3b c0bw3b merged commit 576a82d into NixOS:master Nov 23, 2019
c0bw3b pushed a commit that referenced this pull request Nov 23, 2019
@dasJ @c0bw3b
rainloop-standard: Fix pname and license
382f095 
- Switched to pname
- Fixed the double dash in pname
- Changed license to unfree (they don't allow redistribution)

Fixes #73956
Backport of #73963

(cherry picked from commit 576a82d)
@dasJ dasJ deleted the rainloop-fixup branch November 23, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rainloop-standard: wrong licence and package name
2 participants
@dasJ @c0bw3b